brigadecore / brigade

Event-driven scripting for Kubernetes
https://brigade.sh/
Apache License 2.0
2.4k stars 247 forks source link

docs: footer lacks a copyright notice #1852

Closed krancour closed 2 years ago

krancour commented 2 years ago

Let's add a copyright notice to the footer. Let's also make sure we do not remove attribution for Hugo and the theme we're using. Those should stay.

hamees-sayed commented 2 years ago

@krancour I would like to work on it, can I get more context on the copyright notice?! Am I supposed to link the apache-license to the footer?

krancour commented 2 years ago

Nothing complicated. This works:

© 2017 - 2022 The Brigade Authors

hamees-sayed commented 2 years ago

@krancour can you please also point out the folder where the edit is required? I don't seem to find the specific directory

felipeschulz commented 2 years ago

@hamees-sayed I think its this index.html line 415 (right @krancour ?) https://github.com/brigadecore/brigade-www/blob/9eb7a902d8b901f96f24c0a627996c200a9866ed/index.html

krancour commented 2 years ago

@felipeschulz the brigade-www repo you're referencing is the landing page at https://brigade.sh. That's already got a copyright notice (although it could stand to be updated).

This issue's about the missing copyright notice on the docs site. All of that stuff is under docs/ here in this repo.

felipeschulz commented 2 years ago

Ok, i understood. My fault. So @hamees-sayed , ignore my reply above 😅

krancour commented 2 years ago

No worries. Everyone's still learning their way around. 😄

hamees-sayed commented 2 years ago

@krancour I don't seem to find the footer section in docs/ directory to make an edit. Unlike the brigade-www repo, an HTML file with the footer tag doesn't exist in docs/. It'd be helpful if you could guide me here :)

krancour commented 2 years ago

@hamees-sayed refer to the doc/ folder's own readme for details.

hamees-sayed commented 2 years ago

I went through the entire code but found nowhere the footer which has to be edited. I'll unassign this issue and let someone else work on it