brigadecore / brigade

Event-driven scripting for Kubernetes
https://brigade.sh/
Apache License 2.0
2.4k stars 247 forks source link

Update quickstart.md with root login disclaimer #1878

Closed AnuragThePathak closed 2 years ago

AnuragThePathak commented 2 years ago

Signed-off-by: Anurag Pathak anuragpathak911@gmail.com

Fixes #1544

What this PR does / why we need it: This PR adds a disclaimer regarding the use of root login in a production cluster on the Brigade Quickstart page. Special notes for your reviewer:

If applicable:

netlify[bot] commented 2 years ago

✅ Deploy Preview for brigade-docs ready!

🔨 Explore the source changes: 1b3a7bde343c6aa768b91268d20e1c8e0f8137b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/brigade-docs/deploys/6238935954503f00098ed9d3

😎 Browse the preview: https://deploy-preview-1878--brigade-docs.netlify.app/intro/quickstart

krancour commented 2 years ago

/brig run

AnuragThePathak commented 2 years ago

@krancour is it normal that the brigade:style-check-js workflow is taking around 40+ hours to report the status 🙂

krancour commented 2 years ago

@AnuragThePathak that check is added by #1877, which is not merged yet. It was prematurely marked as a required check in our branch protections. The fact that didn't run can be ignored right now.

krancour commented 2 years ago

Thanks for this @AnuragThePathak !