search

brigadecore / brigade

Event-driven scripting for Kubernetes
https://brigade.sh/
Apache License 2.0
2.4k stars 247 forks source link

fix nightly cleanup job #1892

Closed mariuskimmina closed 2 years ago

mariuskimmina commented 2 years ago

Signed-off-by: Marius Kimmina mar.kimmina@gmail.com

What this PR does / why we need it: Closes #1831 This PR removes the hardcoded list of repositories from the nightly cleanup and instead fetches the list of existing repos from azure.

Special notes for your reviewer: I have tested the nightly-cleanup.sh on my own azure account but I have not yet setup a local brigade cluster to test calling the script from brigade.ts

krancour commented 2 years ago

Hey @mariuskimmina this looks great. I left notes about two small optimizations.

netlify[bot] commented 2 years ago

Deploy Preview for brigade-docs ready!

Name Link
Latest commit e9a0ff1987369730e9d78594d51bbb648881309e
Latest deploy log https://app.netlify.com/sites/brigade-docs/deploys/624334bdf66fca0008f04ae1
Deploy Preview https://deploy-preview-1892--brigade-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mariuskimmina commented 2 years ago

I wasn't aware of the -o table option, that's of course better, this way I also didn't have to trim any quotation marks.

krancour commented 2 years ago

/brig run

krancour commented 2 years ago

/brig run

krancour commented 2 years ago

Thank you so much for this contribution @mariuskimmina!