brigadecore / brigade

Event-driven scripting for Kubernetes
https://brigade.sh/
Apache License 2.0
2.41k stars 246 forks source link

api server: add tests for secrets service #1903

Closed krancour closed 2 years ago

krancour commented 2 years ago

@AnuragThePathak PR'ed a nice improvement to the SecretService in #1900, and discovered that tests for that service were completely missing.

This PR adds them.

Let's get this merged before #1900 so that he can make the incremental test changes that validate the service changes he's made.

netlify[bot] commented 2 years ago

Deploy Preview for brigade-docs ready!

Name Link
Latest commit f437e6f12de250d3cf3025d1d47cd375eea122b6
Latest deploy log https://app.netlify.com/sites/brigade-docs/deploys/62473ecb5d1f2400082f45e2
Deploy Preview https://deploy-preview-1903--brigade-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.