brigadecore / brigade

Event-driven scripting for Kubernetes
https://brigade.sh/
Apache License 2.0
2.41k stars 246 forks source link

chart: don't share secrets across components #1912

Closed krancour closed 2 years ago

krancour commented 2 years ago

This is a very minor and non-breaking chart change.

What it does is prevents the apiserver from having a dependencies on secrets that "owned" by the observer and the scheduler.

This isn't usually a problem, but #1910 will move us to using Tilt to facilitate a tighter, faster "inner-loop" during dev and Tilt has an interesting feature that k8s itself lacks -- the ability to understand dependencies between components in your microservice architecure. We can use this to improve devx a tiny bit further by preventing the apiserver from starting before the database and queue are ready, and we can likewise prevent the observer and scheduler from starting before the apiserver is ready.

If, however, the apiserver depends on secrets "owned" by the observer and scheduler, we create a dependency cycle.

This PR breaks that cycle.

netlify[bot] commented 2 years ago

Deploy Preview for brigade-docs ready!

Name Link
Latest commit aba9d7634cda84af8a0096a571e519a8a37a9619
Latest deploy log https://app.netlify.com/sites/brigade-docs/deploys/62507f2e402f890008045036
Deploy Preview https://deploy-preview-1912--brigade-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.