brigadecore / brigade

Event-driven scripting for Kubernetes
https://brigade.sh/
Apache License 2.0
2.4k stars 247 forks source link

chart: add ability to hard-config API tokens at dev time #1914

Closed krancour closed 2 years ago

krancour commented 2 years ago

A while ago, we introduced behavior in the chart where certain secret values are generated randomly on initial install, but on subsequent helm upgrade operations, existing values are retrieved and reused. This has led to a more stable upgrade process.

This falls apart, however, in cases where there's no cluster to connect to to find existing secrets and you need the secrets to have stable, unchanging values. Namely this can happen when using Tilt (see #1910) at dev time since Tilt never does helm install or helm upgrade, but rather only does helm template and then applies the returned YAML.

i.e. We want this ability if we want to limit unnecessary refreshes of components at dev time just because some token got a new random value every time the chart is rendered.

Note that I did NOT surface this as an option in the values.yaml file because no one should ever hardcode these except to facilitate development.

netlify[bot] commented 2 years ago

Deploy Preview for brigade-docs ready!

Name Link
Latest commit dc0e103462c0f3f7dbe940c2aa5a434d677173b6
Latest deploy log https://app.netlify.com/sites/brigade-docs/deploys/625072260d78750008aa2a75
Deploy Preview https://deploy-preview-1914--brigade-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.