search

brigadecore / brigade

Event-driven scripting for Kubernetes
https://brigade.sh/
Apache License 2.0
2.4k stars 247 forks source link

fix arm64 builds on M1 Macs #1921

Closed krancour closed 2 years ago

krancour commented 2 years ago

Fixes #1920

I'll be honest in saying that I don't know why this simplification works now when it didn't work back #1871 introduced the workaround that caused #1920.

This branch builds fine on my Intel-based Mac and builds fine in CI.

@vdice perhaps on Monday you could validate that this also builds ok on your M1-based Mac?

netlify[bot] commented 2 years ago

Deploy Preview for brigade-docs ready!

Name Link
Latest commit cef66fd36199b3767ded7ef6108005b35b98e6eb
Latest deploy log https://app.netlify.com/sites/brigade-docs/deploys/6250ac02abc4910009a74bd4
Deploy Preview https://deploy-preview-1921--brigade-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

krancour commented 2 years ago

Thanks for validating @vdice!