apiserver: schema: relax regex for git URLs

brigadecore / brigade

Event-driven scripting for Kubernetes

https://brigade.sh/

Apache License 2.0

2.4k stars 247 forks source link

Closed krancour closed 2 years ago

krancour commented 2 years ago

Fixes #1909

cc @emilwangaa

netlify[bot] commented 2 years ago

Name	Link
Latest commit	5aa6378ccc3b7f73f3d7696b29d2fb53a76eb945
Latest deploy log	https://app.netlify.com/sites/brigade-docs/deploys/62603cee38cdaa00081c9107
Deploy Preview	https://deploy-preview-1935--brigade-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Name	Link
Latest commit	78bfc43dd678c1ae5f1f268209be6fc5fd102e14
Latest deploy log	https://app.netlify.com/sites/brigade-docs/deploys/62680880d093f20008a7e664
Deploy Preview	https://deploy-preview-1935--brigade-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

krancour commented 2 years ago

/brig run

emilwangaa commented 2 years ago

krancour commented 2 years ago

does this also need to be updated: https://github.com/brigadecore/brigade/blob/main/sdk/v3/validations.go?

@emilwangaa nice catch! Thanks!

vdice commented 2 years ago

krancour commented 2 years ago

Looks like this PR is still waiting on additions per https://github.com/brigadecore/brigade/pull/1935#issuecomment-1105145169 ?

Indeed. Fixed now though.

krancour commented 2 years ago

Whoooops.... that last change broke a unit test.

Will pick this up again tomorrow.

krancour commented 2 years ago

Rebased and fixed unit tests. This should be g2g for a final review once tests are passed.