brigadecore / brigade

Event-driven scripting for Kubernetes
https://brigade.sh/
Apache License 2.0
2.4k stars 247 forks source link

allow longer event qualifier and label values #1961

Closed krancour closed 2 years ago

krancour commented 2 years ago

I'm not sure why we ever limited the length of qualifiers and labels so aggressively. These are never applied to labels on any k8s resources, so that's not the reason. In all probability, we modeled it after limitations of k8s labels and annotations just in case.

Now there's a good reason to accept longer qualifer and label values -- namely CloudEvents can have very long values in the source field. This is a different source field than the source field on a Brigade event. The CloudEvents gateway always take the value of the CloudEvent's source field and preserves it by popping it into a Brigade event qualifier.

So bottom line is we need this change in order to get the CloudEvents gateway to go GA.

You can already see this works here:

https://dashboard.brigade2.io/projects/acr-demo

Events for that project have very long qualifiers and there has been no issue resulting from that.

(The dogfood Brigade already has these changes.)