search

brigadecore / kashti

Kashti is a dashboard for your Brigade v1 pipelines.
http://kashti.sh
Apache License 2.0
377 stars 46 forks source link

Added Node modules audit build target for Kashti #280

Closed saksham93 closed 4 years ago

saksham93 commented 4 years ago

Added Node modules audit build target for Kashti. Refers to Issue #279

radu-matei commented 4 years ago

The make target is great - now we also need to run the target in our brigade.js file - similar to https://github.com/brigadecore/brigade/blob/9cd050ac7f3ea82e44cbde6164d4dbf681dc5c9b/brigade.js#L48

radu-matei commented 4 years ago

Also note that the target will currently fail due to #281

saksham93 commented 4 years ago

The make target is great - now we also need to run the target in our brigade.js file - similar to https://github.com/brigadecore/brigade/blob/9cd050ac7f3ea82e44cbde6164d4dbf681dc5c9b/brigade.js#L48

@radu-matei Done

radu-matei commented 4 years ago

Excellent!

We should hold off merging this PR until #281 is fixed (so that we avoid the build from master failing), but this will be of very much help going forward, thanks a lot!