search

briggySmalls / late-train-mate

A lightweight website that provides stats on delayed or cancelled UK train services
MIT License
0 stars 0 forks source link

Review app structure #19

Closed briggySmalls closed 6 years ago

briggySmalls commented 6 years ago

At the moment the application has a flat file structure. It also has flat imports that mirror this structure. This is getting pretty unwieldy

You should consider grouping components together, e.g. ResultsComponent and LegComponent (given one appears within the other) into separate directories using a Feature Module much like the current app.module.ts file.

briggySmalls commented 6 years ago

hsp-api.service should probably move to _nationalrail which should be made into a module ...and renamed national-rail while we're at it!