search

briggySmalls / skin-deep-server

Server for the skin deep magazine website
0 stars 1 forks source link

Convert hypens to underscores #165

Open briggySmalls opened 5 years ago

briggySmalls commented 5 years ago

In general filenames and database names should use underscores not hypens.

A great example of the problems this could cause is the fact that Sage assumes hypens in filenames to be a 'fallback separator', but also uses get_post_type() to build template file names.

Thus single-sd-product will have fallbacks single-sd and single, which is unexpected (although unlikely to ever be a problem.

The models and ACF fields should probably be cleaned up to reflect this.

briggySmalls commented 5 years ago

Wordpress codex states this explicitly:

The name of the taxonomy. Name should only contain lowercase letters and the underscore character, and not be more than 32 characters long (database structure restriction).