Image size issues - Githubissues

briggySmalls / skin-deep-server

Server for the skin deep magazine website

0 stars 1 forks source link

Image size issues #212

Closed briggySmalls closed 4 years ago

briggySmalls commented 5 years ago

Images should be uploaded as hi-res 16:9 images
Wordpress should crop any hi-res images that are not this aspect, to 16:9
The slider currently shows images that are not 16:9. This is stopping people using it.

Questions are:

Why is https://skindeepmag.com/articles/bronx-gothic-an-exploration-of-freedom-trauma-and-the-limits-of-black-girlhood/ not 16:9?
Will the slider work with all 16:9 images as it stands?

briggySmalls commented 4 years ago

The uploads folder definitely contains 16:9 cropped versions of the particular example mentioned. The original image is not 16:9 but sufficiently high resolution for the correct aspect ratio to be used.

briggySmalls commented 4 years ago

Currently if there is a higher resolution image available (it is included in the srcset) then there is nothing stopping the browser from taking it. Sure it doesn't have to, given a fairly large one is still availalbe, but there's nothing stopping it.

Thus the attempts in #85 are working, but were based on a misunderstanding of how the browser would use this information

briggySmalls commented 4 years ago

The kludge would be that the original image is only added to the srcset if there is no 'large' size available (i.e. original image was too small for 16:9)

briggySmalls commented 4 years ago

Large size always seems available, but we can check that the large size is the correct aspect ratio