search

brightcove / hot-shots

Node.js client for statsd, DogStatsD, and Telegraf
MIT License
527 stars 135 forks source link

StatsD ClientOptions interface is missing `stream` property #233

Closed albert-mirzoyan closed 2 years ago

albert-mirzoyan commented 2 years ago

The runtime supports the stream option https://github.com/brightcove/hot-shots/blob/master/lib/statsd.js#L64 But the types.d.ts is missing the declaration. https://github.com/brightcove/hot-shots/blob/master/types.d.ts#L5

bdeitte commented 2 years ago

Thanks for the heads up. PRs are always welcome, or I'll try to remember this the next time I'm merging things and making updates.

bdeitte commented 2 years ago

I am making a small update myself right now, and I was going to put this in. But I'm not using TypeScript and wasn't 100% sure the type should be Stream. So until next time I make a change, or someone else can submit the PR.