brightcove / hot-shots

Node.js client for statsd, DogStatsD, and Telegraf
MIT License
527 stars 135 forks source link

Request to enable buffering by default for UDS connections #244

Open imsodin opened 1 year ago

imsodin commented 1 year ago

I got a lot of the congestion errors, which are mentioned in the readme. To resolve those, I didn't need to change any system settings like suggested in the linked section there, just enabling buffering in hot-shots solved it. Datadog agent by default has a 8KiB buffer and recommends using buffering at clients (https://docs.datadoghq.com/developers/dogstatsd/high_throughput/?#enable-buffering-on-your-client), so I used that value for maxBufferSize. Unless there are any downsides, it seems like the user experience would be improved by making that the new default for UDS. Or if that's a problem with other servers/agent than datadog, I'd suggest to first recommend enabling the buffer in the readme and only if that doesn't help refer to the section currently linked about system settings.