search

brightcove / videojs-thumbnails

A video.js plugin that displays thumbnail images over the scrubber.
Other
168 stars 97 forks source link

forked example.html does not work #1

Closed brendosthoughts closed 11 years ago

brendosthoughts commented 11 years ago

hey, I've forked your project as I'd like to use it in my site however when testing the example i get errors (in chrome) has something been broken or am I doing something wrong? any insight would be awesome thanks for the code ... if this is a real issue just confirm if for me

jrw95 commented 11 years ago

Hello, Can you provide more detail on what errors you're seeing? Also, are you able to reproduce these errors in other browsers? Thanks

brendosthoughts commented 11 years ago

in chrome and opera im getting the error's :

Failed to load resource file:///C:/Users/dmorrison/AppData/Local/Apps/2.0/VDECZ306.N69/HX8CZARC.BYV…94/Desktop/videojs-thumbnails/node_modules/video-js/4.0.0-pre/video-js.css Failed to load resource file:///C:/Users/dmorrison/AppData/Local/Apps/2.0/VDECZ306.N69/HX8CZARC.BYV…9f6b94/Desktop/videojs-thumbnails/node_modules/video-js/4.0.0-pre/video.js Uncaught ReferenceError: videojs is not defined videojs.thumbnails.js:29 Uncaught ReferenceError: videojs is not defined example.html:32

In firefox no mime-type to support playback.

... All I've done is fork + cloned repository to local machine. And attempted to run the example.html just to see how the plugin looks. however in the head of the document or elsewhere in the document I do not see either part of setup for video.js ie

So I am thinking that there needs some setup, to actually run example.html?

I'm going to attempt to use the plugin in other code I know is working tonight, I'm not sure if I am just not seetting things up correctly? I opened the issue cause if your going to have an 'example.html' it really should work. Hope this helps, Anything else I can do let me know, I will post feedback about using the plugin with other video's when I have had a chance to set that up

jrw95 commented 11 years ago

A couple of things I'd recommend that might help:

  1. Refer to the CONTRIBUTING.md doc, and set up and build the project.
  2. Rather than load the files directly from the file system, use a http server.

I'll see if I can replicate the errors you're seeing in the meantime.

brendosthoughts commented 11 years ago

hey so, I set it up on server and im getting the same errors... I Also attempted to set it up in another area which uses video.js and had no such luck I get a javascript error when the plugin attempts register itself saying videojs is not defined . I also posted a question about correct steps to register plugins on SO you can check out here http://stackoverflow.com/questions/16368959/how-to-register-a-video-js-plugin also the link to my example.html on a server can be found here: http://ec2-50-17-75-42.compute-1.amazonaws.com/videojs-thumbnails/example.html

dmlap commented 11 years ago

I dropped a copy of video.js into a node_modules directory when developing the plugin since 4.0 isn't released yet. If you download a copy from zencoder/video-js and then update the links in the example to point to it, the plugin should work. I believe 4.0 is coming out in the next week or so. I'll update the example in the plugin to point to the public CDN URL as soon as that happens.