search

brightcove / videojs-thumbnails

A video.js plugin that displays thumbnail images over the scrubber.
Other
168 stars 97 forks source link

Sponsor WebVTT support #22

Closed Cervenka closed 9 years ago

Cervenka commented 10 years ago

We'd like to sponsor an additional feature: Scrubbing thumbnails support for WebVTT with spacial fragments for sprites. JWPlayer currently supports that. (http://support.jwplayer.com/customer/portal/articles/1407439-adding-preview-thumbnails)

If someone is interested please contact me at florian@cervenka.at.

dmlap commented 10 years ago

Definitely! I'll drop you a line over email.

dirkjanm commented 9 years ago

Is there any progress/changes on this? I'm interested in it as well

Cervenka commented 9 years ago

Hi. The plugin is done. I'll ask the developer to publish it on github once we wrapped up some last items and paid him. Feel free to bug me again in December if I don't get back to you.

Am Donnerstag, 13. November 2014 schrieb Dirk-jan :

Is there any progress/changes on this? I'm interested in it as well

— Reply to this email directly or view it on GitHub https://github.com/brightcove/videojs-thumbnails/issues/22#issuecomment-62870101 .

Sent from my phone

Cervenka commented 9 years ago

Oh, by the way. We ended up not using WebVTT but rather have the plugin show the thumbnails based on an interval and the length of the video.

Kind regards, Florian Cervenka

Florian Cervenka Chief Technical Officer Shared Media

On Thu, Nov 13, 2014 at 11:43 AM, Florian Cervenka florian@shared.com wrote:

Hi. The plugin is done. I'll ask the developer to publish it on github once we wrapped up some last items and paid him. Feel free to bug me again in December if I don't get back to you.

Am Donnerstag, 13. November 2014 schrieb Dirk-jan :

Is there any progress/changes on this? I'm interested in it as well

— Reply to this email directly or view it on GitHub https://github.com/brightcove/videojs-thumbnails/issues/22#issuecomment-62870101 .

Sent from my phone

Bite-A-Rock commented 9 years ago

Hi, any news on this? Would love this capability...

dmlap commented 9 years ago

Quick update: we've been working on adding metadata track support to video.js. We're holding off on making any big enhancements to this plugin until that's in place so we don't re-invent the wheel.

dirkjanm commented 9 years ago

For those still interested in this, I've created a fork which works exclusively with WebVTT files and the new metadata track support in video.js: https://github.com/dirkjanm/videojs-vtt-thumbnails

dmlap commented 9 years ago

@dirkjanm that's awesome! I'm going to close this since your plugin solves the issue for anyone who wants thumbnails through WebVTT.

dirkjanm commented 9 years ago

So you want to keep this plugin in the current style? I wasn't sure yet if you wanted to pull the code in any way or that I should "release" it as a separate plugin.

dmlap commented 9 years ago

@dirkjanm it would be awesome to merge VTT support into this project if you're up for it. Feel like opening a PR?

dirkjanm commented 9 years ago

I dont mind making one but you should not that it only supports VTT and not the old config style anymore since I found that one way too complicated when trying to use more complicated image setups.

dmlap commented 9 years ago

As long as the VTT-based configuration is easy, I'd be up for bumping the major version and dropping support for the old config syntax.

dirkjanm commented 9 years ago

It's as easy as adding a metadata track to the video object. I updated the Readme.md as well to reflect the new config style. I'll test some more next week on how it works with WebVTT files which don't have explicitly specified image dimensions and once that works I'll create a PR.

dmlap commented 9 years ago

Sounds great!