search

brightcove / videojs-thumbnails

A video.js plugin that displays thumbnail images over the scrubber.
Other
168 stars 97 forks source link

Adding support to HLS container #25

Closed monsieurludo closed 9 years ago

monsieurludo commented 9 years ago

For some reason, durationchange doesn't work when the container is HLS/Flash. The first thumbnail is showing but isn't updating on any browser when the mouse hovers over the scrubber.

Not sure if HLS should fire an event on duration but in the meantime, this does the trick.

gkatsev commented 9 years ago

Looks good. Can you give more background on the setup and why you're experiencing this problem? How is HLS being loaded?

monsieurludo commented 9 years ago

Thanks, I had to replicate an existing player so I added this thumbnail plugin and tried with my (Brightcove) account.

When video files are MP4 only, then there is no problem but if M4TS renditions are present, then Brightcove automatically wraps them in a swf container as you can see on: http://solutions.brightcove.com/lchok/ma/thumbs/bcove2.html (thumbnails not matching content)

'loadedmetadata' does the same listening for flash events.

On 2 December 2014 at 15:45, Gary Katsevman notifications@github.com wrote:

Looks good. Can you give more background on the setup and why you're experiencing this problem? How is HLS being loaded?

— Reply to this email directly or view it on GitHub https://github.com/brightcove/videojs-thumbnails/pull/25#issuecomment-65250733 .

gkatsev commented 9 years ago

Ah, ok, looks like the issue is in the contrib-hls project. We should probably look into fixing it there, if possible.

@dmlap any objections into pulling this in?

dmlap commented 9 years ago

@creeptonik Thanks for the patch! I released v0.1.1 with this fix included.