Change plugin logic to work with VTT files

brightcove / videojs-thumbnails

A video.js plugin that displays thumbnail images over the scrubber.

Other

168 stars 97 forks source link

Change plugin logic to work with VTT files #27

Open dirkjanm opened 9 years ago

dirkjanm commented 9 years ago

Changed plugin to work with VTT files as a metadata track on the player as discussed in #22
Added example VTT file and image
Support for mediafragments in VTT files
Width/height fallback in case the width/height is not specified in the VTT file
Updated documentation
Bumped version

dmlap commented 9 years ago

This looks really great! I only have one comment, and it's definitely a nitpick. In the rest of the Brightcove video.js plugins, we try to be consistent about putting whitespace around operators and including the optional curly-braces for single-line ifs. Would you mind adding those?

dirkjanm commented 9 years ago

@dmlap I think this should take care of them all.

dirkjanm commented 9 years ago

@dmlap Any update on this?

Iragne commented 9 years ago

dirkjanm commented 9 years ago

just reminding @dmlap that this one is still open

u0x01 commented 8 years ago

Seems this is not working for me with videojs v5.4.6, I'm not sure what problem happened, can you fix it and update your demo work? thanks lot!

aolko commented 5 years ago

is it going to be merged or what? @dmlap