search

brightcove / videojs-thumbnails

A video.js plugin that displays thumbnail images over the scrubber.
Other
168 stars 97 forks source link

Images are showing at incorrect time on seekbar #43

Open iamprem opened 6 years ago

iamprem commented 6 years ago

I've been trying to use this plugin for displaying thumbnail images and i noticed that time in seconds configured is not actually matching the timestamp in seek bar for a given image. I tried removing "progressControl.el().offsetLeft" from the following line and then it seem to work correctly. Not sure if this is due to recent ControlBar changes in videojs. Without this "possible fix" i'm getting negative values for "mouseTime".

https://github.com/brightcove/videojs-thumbnails/blob/a3ac343c2c66b5d2250604cd570d476c1ef25412/videojs.thumbnails.js#L152

Let me know if you need any more examples or details about this bug.

Sergey-bhw commented 6 years ago

Same here, did as you wrote and its working as it should. Thanks.