use pageXOffset instead of screenX so the thumbs move in IE

brightcove / videojs-thumbnails

A video.js plugin that displays thumbnail images over the scrubber.

Other

168 stars 97 forks source link

use pageXOffset instead of screenX so the thumbs move in IE #5

Closed jgubman closed 11 years ago

jgubman commented 11 years ago

I guess screenX isn't supported in IE, so left gets assigned to NaN. Use pageXOffset to work around this issue

dmlap commented 11 years ago

Did you test this against non-IE browsers?

jgubman commented 11 years ago

Yeah, tested against all browsers we support (recent versions of chrome, safari, firefox and ie9/10). It's running in production if you want to take a look at:

http://www.funnyordie.com/videos/6b0b308f41/coming-soon-from-funny-or-die-with-will-ferrell

dmlap commented 11 years ago

Looks good to me. Thanks for the patch!