search

brightcove / videojs-thumbnails

A video.js plugin that displays thumbnail images over the scrubber.
Other
168 stars 97 forks source link

don't let the thumb scroll off the edge of the video #6

Closed jgubman closed 11 years ago

jgubman commented 11 years ago

Keep the images inside the outer bounds of the video so the thumbnail doesn't get cutoff when hovering over the beginning and end of the progressControl

asasi commented 11 years ago

I tested this out on Chrome, and what I'm seeing is that the thumbnail won't follow the mouse, it seems to be locked into the middle of the video duration bar.

What did you test this on?

jgubman commented 11 years ago

hmmm, I tested in Chrome, Safari and firefox (all on mac), seems to be ok for me.

On Oct 1, 2013, at 7:34 AM, asasi notifications@github.com wrote:

I tested this out on Chrome, and what I'm seeing is that the thumbnail won't follow the mouse, it seems to be locked into the middle of the video duration bar.

What did you test this on?

— Reply to this email directly or view it on GitHub.

asasi commented 11 years ago

I deleted and reinstalled videojs-thumbnails, and remade the branch. I'm still seeing the player do this: screen shot 2013-10-02 at 11 46 51 am

You can look at my console in the right corner, it will show you how I made the branch, if that makes a difference. It doesn't look like screen shot captures the mouse, but mine was right above the mute button.

jgubman commented 11 years ago

Ah, I forgot the plugin supports one large stitched together thumbnail, we're using individual thumbs.

I'll take a look at supporting both use cases.