brighthive / master-client-index

BrightHive's Master Client Index framework.
MIT License
2 stars 2 forks source link

Should an empty `users` endpoint return a 404? #27

Closed reginafcompton closed 4 years ago

reginafcompton commented 4 years ago

Currently, the users endpoint returns a 404 status code, the user table does not have any records.

https://github.com/brighthive/master-client-index/blob/3afaedcbcd405d0a252ad753e52768d1130c2635/mci/api/v1_0_0/user_handler.py#L209-L213

This seems odd, since the endpoint still returns valid JSON. Plus, the other endpoints do not behave as such.