Closed s-andringa closed 9 years ago
+1 for removing inherited resources, since it is deprecated, but that will probably be more work than just capping the Rails version for now,
I actually got it working just this week with rails 4.2 and inherited resources. Will report back soon!
Nevermind, I see you proposed to use the rails-4-2
branch, somehow missed that, but thats how I got it working :disappointed:
I see no reason not to merge this asap, @stefanroex, @jvdp ?
Sounds good to do this until we can get rid of inherited_resources (or fix this issue some other way...)
The inherited_resources gem is not compatible with Rails 4.2, as responders have been taken out of Rails. Brightcontent requires Rails >= 4.0.0 and inherited_resources ~> 1.4.1, meaning that with a clean install it currently would try to load Rails 4.2, resulting in
NameError: uninitialized constant ActionController::Responder
. Here's what we could do:rails-4-2
branch, but I'm not sure how stable it isUntil either of the options above is implemented brightcontent breaks down when used in Rails 4.2 projects. This PR restricts its dependency on Rails to version < 4.2, in order to prevent unexpected errors.