Adjustable pagination - Githubissues

brightin / brightcontent

BrightContent, yet another cms / admin panel for Rails

brightin.nl

MIT License

12 stars 13 forks source link

Adjustable pagination #43

Closed martijnbleeker closed 8 years ago

martijnbleeker commented 8 years ago

Add adjustable page sizes for pagination.

If page_size_options is set in a controller, the index view will get page size options next to the page selection.

Example for page_size_options:

page_size_options [10, 30, 50, 100, 200]

[x] Fix bug where filters are cleared on page_size change
[x] Fix bug where page_size is cleared on filter change
[x] Fix bug where page_size selection is visible on empty list

jvdp commented 8 years ago

Hi @martijnbleeker, thanks for the PR! Looks like a useful feature.

I have a posted a few suggestions, please let me know what you think.

martijnbleeker commented 8 years ago

Hi @jvdp, thanks for your feedback. I've processed it and committed the changes. Also, we've encountered some minor bugs in the meantime, those have been fixed as well. (See checkboxes in the initial PR comment)

jvdp commented 8 years ago

Thanks, looks good!