ContributionAnalysis.sort_array

[Zoophobus]

Hi,

first of all thanks for all the great work. Second this is a small issue and is related to the method used to order the contributions. If you disagree with what I feel about this then I would love to hear your feedback and arguments, I'm pretty stubborn but do try to listen to wisdom! The issue is around the use of the literal values, rather than what I would describe as the weight (e.g. the degree of impact, using the absolute of a value) that a parameter (be it a method, or process) has on a factor, for ordering those parameter contributions.

Working on the visualisations in the AB using the literal value means that there is no capability for us, or the users to investigate the impacts when there is a negative contribution to a factor. Hence part of why I would argue that there should be a change to the ContributionAnalysis.sort_array method, so that it would order the parameters according to their weights on the factor. I also think this would provide users with a better view on the actual degree of impact the parameters have on the factor they are trying to analyse.

I hope you agree, otherwise I look forward to trying to argue with you

[Zoophobus]

BTW I am only referring to the version 2 of brightway, not the later bw2.5 versions