overhaul of LCA.to_dataframe()

brightway-lca / brightway2-calc

The calculation engine for the Brightway2 life cycle assessment framework.

BSD 3-Clause "New" or "Revised" License

12 stars 15 forks source link

overhaul of LCA.to_dataframe() #33

Closed BenPortner closed 2 years ago

BenPortner commented 4 years ago

should fix #31
use pandas methods for sorting --> syntax is easier to understand (in my opinion) and easier to extend (e.g. sorting on other columns, adding new columns)
drawback: slightly slower than the solution proposed by @mfastudillo

cmutel commented 3 years ago

Hi @BenPortner! Sorry, I am not sure why, but I am only seeing this now.

This is a great idea; 2.5 will make it slightly more complicated, but I will merge soon, as soon as I have time to resolve the conflicts. Thanks a lot!

tngTUDOR commented 2 years ago

I might be wrong, but I have the impression that this PR concerns 2 different, unrelated issues: #31 and #32. It would be easier if we had only one issue to fix per PR @BenPortner.

cmutel commented 2 years ago

See https://github.com/brightway-lca/brightway2-regional/blob/master/bw2regional/export.py#L29 for another idea on dataframes.

BenPortner commented 2 years ago

Thanks for checking the PR @tngTUDOR. I will address the raised issues once https://github.com/brightway-lca/brightway2-io/pull/114 and https://github.com/brightway-lca/brightway2-data/pull/91 are solved, as I consider these high(er) priority.

cmutel commented 2 years ago

Closing this in favor of 3f360c913f8d257aeabe4a7a754a1939de506c1a, which follow the conventions introduced in bw2data, relative and absolute cutoffs, manual specification of row and col dicts, works with and without bw2data, and allows for dataframes from any matrix.