brightway-lca / brightway2-data

Tools for the management of inventory databases and impact assessment methods. Part of the Brightway LCA framework.
https://docs.brightway.dev/
BSD 3-Clause "New" or "Revised" License
8 stars 21 forks source link

fix d489a12 #126

Closed BenPortner closed 1 year ago

BenPortner commented 1 year ago

Commit d489a12 introduced a new fix_location function, which causes problems:

In consequence, tests are failing. This PR fixes the function. However, it is hard to tell if this fix preserves all desired new functionality because d489a12 included no tests. Is there anyone who can check this and add the necessary tests? Perhaps @macmribo?

@cmutel we need to be more careful before merging PRs.