Closed will7200 closed 3 months ago
Attention: Patch coverage is 90.00000%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 83.24%. Comparing base (
802dafe
) to head (0c61d18
). Report is 14 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
bw2data/updates.py | 22.22% | 7 Missing :warning: |
bw2data/search/indices.py | 95.95% | 4 Missing :warning: |
bw2data/search/schema.py | 87.87% | 4 Missing :warning: |
bw2data/search/search.py | 94.44% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@will7200 Awesome! One small comment which is an easy fix, and then fix some test failures, and we should be GTG!
@cmutel fixed that and found the underlying causing those test failures. The last two remaining windows failures are due to:
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpgwrprhc7\\dxbqkfxeszgknljeyz.46382e12\\lci\\databases.db'
Which looks like has happened in past github runs.
Closes #103
This aims to be a drop in replacement for whoosh. with little to no API change for our customers.