search

brightway-lca / brightway2-data

Tools for the management of inventory databases and impact assessment methods. Part of the Brightway LCA framework.
https://docs.brightway.dev/
BSD 3-Clause "New" or "Revised" License
8 stars 21 forks source link

technosphere() should return also subsitution #48

Closed aleksandra-kim closed 7 years ago

aleksandra-kim commented 7 years ago

Original report by giuseppe cardellini (Bitbucket: cardosan, GitHub: cardosan).

this should return also exchanges of type substitution being part of the technosphere matrix.

aleksandra-kim commented 7 years ago

Original comment by Chris Mutel (Bitbucket: cmutel, GitHub: cmutel).

Maybe instead of including substitution exchanges to the technosphere(), we should add a new .substitution() method?

aleksandra-kim commented 7 years ago

Original comment by giuseppe cardellini (Bitbucket: cardosan, GitHub: cardosan).

this can also be added as a separate method, but I still think also subsitution exchanges should be returned by technosphere() being also them part of the technosphere matrix and thus are technosphere exchanges (even if with flipped sign). I think this is the behaviour most people would expect from this method (myself also)

aleksandra-kim commented 7 years ago

Original comment by Chris Mutel (Bitbucket: cmutel, GitHub: cmutel).

Fix #48. Include substitution in technosphere exchanges iterator