search

brightway-lca / brightway2-data

Tools for the management of inventory databases and impact assessment methods. Part of the Brightway LCA framework.
https://docs.brightway.dev/
BSD 3-Clause "New" or "Revised" License
8 stars 21 forks source link

Python 3.8 new highest pickle protocol version #68

Closed aleksandra-kim closed 4 years ago

aleksandra-kim commented 4 years ago

Original report by Daniël de Koning (Bitbucket: dgdekoning, GitHub: dgdekoning).

Not exactly an issue or problem, but can be confusing for people using brightway with multiple versions of python.

In python 3.8 the pickle.HIGHEST_PROTOCOL version is now 5 after PEP-574.

This means that any brightway objects pickled in version 3.8 of python can no longer be deserialized when using any version of python lower than 3.8.

Would it be possible to use specific protocol versions (2 for python 2.7 and 4 for python 3) instead of preferring the highest one?