defer import of `project.py` into `utils.py` to prevent circular import error

brightway-lca / brightway2-data

Tools for the management of inventory databases and impact assessment methods. Part of the Brightway LCA framework.

https://docs.brightway.dev/

BSD 3-Clause "New" or "Revised" License

8 stars 21 forks source link

defer import of `project.py` into `utils.py` to prevent circular import error #77

Closed BenPortner closed 3 years ago

BenPortner commented 3 years ago

fixes the issue described and introduced in https://github.com/brightway-lca/brightway2-data/pull/75#issuecomment-764522082

BenPortner commented 3 years ago

Unfortunately, I cannot test whether this introduces new problems because tests are not running in general. The recent changes to bw_processing cause tests to fail. Will open new issue for this.

bsteubing commented 3 years ago

Hi @BenPortner, I am sorry this is still causing trouble for you. I have currently no time to contribute to this (or even look at it in detail), but I hope this was the solution now or if not feel free to also completely revert the changes that I proposed. The only thing that I was looking for is a brightway implementation for using a different bw data directory than the default one (or simply a convenient way of switching the data location).

cmutel commented 3 years ago

Hi Ben- This is exactly the right idea, and I actually added it before noticing that you had also submitted a PR. So I am closing this, but it is merged in spirit :)