search

brightway-lca / brightway2-io

Importing and exporting for the Brightway LCA framework
BSD 3-Clause "New" or "Revised" License
26 stars 40 forks source link

Bw2legacy #160

Closed ccomb closed 1 year ago

ccomb commented 1 year ago

Backport #157 and try to fix #159

However I'm unsure about the case where an allocation=0 since there is a ZeroDivisionError Anyway with this fixes I ended up importing the Agribalyse 3.1.1 csv exported from simapro

ccomb commented 1 year ago

I have assumed that bw2legacy is some kind of main branch for bw 2.0, and can replace 0.8.8. Am I right?

BenPortner commented 1 year ago

I'm reverting this PR because it breaks the tests. @ccomb please fix the errors and open a new PR after. @cmutel do you have any idea why tests were skipped for all commits to this PR?

cmutel commented 1 year ago

@BenPortner I see green checkmarks everywhere, and passing tests, e.g. https://github.com/brightway-lca/brightway2-io/runs/12035434566. Are the tests broken in CI or on your machine?

BenPortner commented 1 year ago

@cmutel the tests are broken in the CI and on my machine. If you hover over the checkmarks you will see that all of the tests have been skipped for some reason. If you check https://github.com/brightway-lca/brightway2-io/commit/bb889ea9bfd4a2f7befc19746f29a489803b7e71 you will see that tests failed once they ran.

ccomb commented 1 year ago

Thanks and sorry, I'll check all that as soon as I can!

On March 17, 2023 12:54:55 PM GMT+01:00, "Benjamin W. Portner" @.***> wrote:

@cmutel the tests are broken in the CI and on my machine. If you hover over the checkmarks you will see that all of the tests have been skipped for some reason. If you check https://github.com/brightway-lca/brightway2-io/commit/bb889ea9bfd4a2f7befc19746f29a489803b7e71 you will see that tests failed once they ran.

-- Reply to this email directly or view it on GitHub: https://github.com/brightway-lca/brightway2-io/pull/160#issuecomment-1473719952 You are receiving this because you were mentioned.

Message ID: @.***>

ccomb commented 1 year ago

It's just the test result that was wrong: 3.2085 instead of 32.085. Doing another PR