search

brightway-lca / brightway2-io

Importing and exporting for the Brightway LCA framework
BSD 3-Clause "New" or "Revised" License
26 stars 40 forks source link

Redo #160 #170

Closed ccomb closed 1 year ago

ccomb commented 1 year ago

Fix #156 #159 and redo broken PR #160 Don't pin numpy, evaluate expressions in allocations, convert exponent in simapro csv import

BenPortner commented 1 year ago

Hi @ccomb,

Let's move the eval replacement to a new PR and get everything else merged for now. Can you roll back the eval change and make sure all tests are passing?

Cheers. Ben

ccomb commented 1 year ago

The problem with using only asteval is that the parameter variables are not evaluated and I get a lot of warnings in the console during an ecoinvent import, but I had some troubles with bw2parameter also. I'll try to find some time in the next two or three weeks to find a solution. In the meantime I'll split this PR into smaller ones.

ccomb commented 1 year ago

I created another PR #201 with just asteval (But still waiting for asteval 0.9.30 with https://github.com/newville/asteval/pull/116 from @newville)