Closed ccomb closed 1 year ago
@cmutel asteval 0.9.30 is released, so this PR can be merged
Thanks @ccomb
isinstance(number, (int, float))
to isinstance(number, Number)
, and add from numbers import Number
?eval
is unsafe for arbitrary user input, as reminded by @BenPortner
Or maybe you were expecting I replace asteval.Interpreter
with bw2parameters.Interpreter
and add bw2parameters as a dependency of bw2io ? Please tell
@ccomb
Or maybe you were expecting I replace asteval.Interpreter with bw2parameters.Interpreter
Exactly :)
and add bw2parameters as a dependency of bw2io
Yes. In fact, bw2parameters is already an indirect dependency of bw2io via bw2data. However, we should now add bw2parameters as a direct dependency in setup.py
and requirements.txt
.
Replaced by #206
Replaced eval with asteval.
(extracted from #170 )
But still waiting for asteval 0.9.30 with newville/asteval#116 from @newville