brightway-lca / brightway2-io

Importing and exporting for the Brightway LCA framework
BSD 3-Clause "New" or "Revised" License
26 stars 40 forks source link

Missing attribute during import (fixes #196) #217

Closed ccomb closed 10 months ago

ccomb commented 1 year ago

fixes #196

cmutel commented 1 year ago

Hey, this is awesome but definitely needs a test.

cmutel commented 11 months ago

@ccomb Ready to merge if we get a test

ccomb commented 10 months ago

Sure, sorry, I'll try to find a moment this week !

ccomb commented 10 months ago

Added a test ! (and fixed a conversion bug for comments)