search

brightway-lca / brightway2-io

Importing and exporting for the Brightway LCA framework
BSD 3-Clause "New" or "Revised" License
26 stars 40 forks source link

Duplicate strategy #218

Closed ccomb closed 10 months ago

ccomb commented 10 months ago

Just noticed that when using SimaProLCIACSVImporter, the set_biosphere_type strategy is applied twice. This is because self.strategies is defined as

            self.strategies = [
                normalize_units,
                set_biosphere_type,
                normalize_simapro_biosphere_categories,
                normalize_simapro_biosphere_names,
            ] + self.strategies[1:]

And the strategies of the base class is

        self.strategies = [
            normalize_units,
            set_biosphere_type,
            drop_unspecified_subcategories,

There are no consequences except the loss of a few seconds during import.