brightway-lca / brightway2-io

Importing and exporting for the Brightway LCA framework
BSD 3-Clause "New" or "Revised" License
27 stars 42 forks source link

Importing ecospold1 fails due to unset variable in extractor #59

Closed aleksandra-kim closed 5 years ago

aleksandra-kim commented 5 years ago

Original report by Daniël de Koning (Bitbucket: dgdekoning, GitHub: dgdekoning).


Hello!

I am using version 0.7.4 of bw2io on windows 10 through miniconda3 and attempting to import ecospold1 datasets into brightway.

During this process I found that any importer class using the Ecospold1DataExtractor will fail due to the process_file method using filename instead of filepath in its print statements.

My fix to this was to change the filename variable to filepath, which revolved the error.

aleksandra-kim commented 5 years ago

Original comment by Chris Mutel (Bitbucket: cmutel, GitHub: cmutel).


Fix #59

aleksandra-kim commented 5 years ago

Original comment by Chris Mutel (Bitbucket: cmutel, GitHub: cmutel).


Fixed in 0.7.5 release (2019-06-17)

aleksandra-kim commented 5 years ago

Original comment by Daniël de Koning (Bitbucket: dgdekoning, GitHub: dgdekoning).


Cheers!