search

brightway-lca / brightway2-parameters

Library for storing, validating, and calculating with parameters
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Add fixes for ecoinvent units #10

Open BenPortner opened 8 months ago

BenPortner commented 8 months ago

This PR adds a couple of fixes, which are necessary to use the new PintInterpreter with ecoinvent databases. Ecoinvent uses some specific units (like EUR2005, Sm3, unit), which cannot be interpreter by pint out of the box. I added a ecoinvent_units.txt file to easily add these definitions to pint. I also wrote tests to make sure they are imported correctly.

@cmutel I am not sure if the definition file should be in bw2parameters or rather in bw2data. What do you think?

BenPortner commented 8 months ago

Successful workflow result here: https://github.com/brightway-lca/brightway2-parameters/actions/runs/7966380898/job/21747522619 (dunno why Github doesn't show it on the MR...)

BenPortner commented 8 months ago

@cmutel not pushing, just making sure you've noticed my answer.