brightway-lca / brightway25

A wrapper library for documentation and easy installation of Brightway 2.5
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

Issue with the ActivityDataset update? #3

Closed RomainBes closed 1 year ago

RomainBes commented 1 year ago

I tried to update the activity dataset attributes, but it seems there is a bug, or something I'm doing wrong.

After importing : from bw2data.backends import ActivityDataset as AD

I tried to update the activity name as in this notebook by executing the command: AD.update(name="Wow, this is some car!").where(AD.name == 'Combustion car').execute()

The change appears to be partially effective because, using the get_node() function, I can get the activity with its new name, but the output still has the old name...

image

Thanks for your feedback on this issue,

Romain

PS: The same behavior happens for the ExchangeDataset.

The brightway version is: bw-migrations 0.2 bw-processing 0.8.2 bw2analyzer 0.11.4 bw2calc 2.0.dev12 bw2data 4.0.dev18 bw2io 0.9.dev11 bw2parameters 0.7

cmutel commented 1 year ago

Yes, this is a bug which is fixed in git but the fix is not yet released. But thanks, it is good to have a reminder!

RomainBes commented 1 year ago

Ok, I'll close the issue and wait for the next release!

cmutel commented 1 year ago

I am working on it, need to put out fires before rebuilding the structure...