brightway-lca / bw_graph_tools

Graph traversal class and utilities
https://docs.brightway.dev/projects/graphtools/en/latest/
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Update to scikit-network `>=0.31` #13

Closed cmutel closed 1 year ago

cmutel commented 1 year ago

scikit-network 0.31 changed the call signature for get_shortest_path from:

def get_shortest_path(
    adjacency: sparse.csr_matrix, 
    sources: Union[int, Iterable], 
    targets: Union[int, Iterable],
    method: str = 'D', 
    unweighted: bool = False, 
    n_jobs: Optional[int] = None
):

to

def get_shortest_path(
    input_matrix: sparse.csr_matrix, 
    source: Optional[Union[int, Iterable]] = None,
    source_row: Optional[Union[int, Iterable]] = None,
    source_col: Optional[Union[int, Iterable]] = None, 
    force_bipartite: bool = False
):

We need to test this new function, and decide how to support the latest versions.

cmutel commented 1 year ago

Fixed in 12d254434e5993eac7dc39b5606040c72ba7abb7