search

brightway-lca / bw_hestia_bridge

Consume the HESTIA API in Brightway
https://docs.brightway.dev/projects/hestiabridge/
MIT License
1 stars 0 forks source link

Simpler querying #27

Closed cmutel closed 1 year ago

cmutel commented 1 year ago
tfardet commented 1 year ago

This feels like duplicating existing functions, so maybe we should rather discuss if we should change the existing ones so they suit everyone?

One can already switch the API via set_config("hestia_api", url) and the download is via

get_hestia_node({"@ntype": ntype, "@id": nid}, data_state="original/recalculated")

so one can reuse directly the results returned by the search function. If this is not how you think we should proceed then I'd rather discuss how to improve it rather than to add another function doing the same thing.

tfardet commented 1 year ago

I will simplify the get_hestia_node function