search

brightway-lca / bw_hestia_bridge

Consume the HESTIA API in Brightway
https://docs.brightway.dev/projects/hestiabridge/
MIT License
1 stars 0 forks source link

Related cycles and node type autodetect #44

Closed tfardet closed 1 year ago

tfardet commented 1 year ago

Add get_node_type function. Add get_cycle_graph

Fixes #47

tfardet commented 1 year ago

@cswh all yours for the test and then ping Chris so he can check and merge it?

cswh commented 1 year ago

I have added a test for the graph cycle search. However I have some mixed feelings about using specific (e.g. id dependent) API calls for the tests. If there are changes within the staging server of hestia (e.g. a different name or id for a cycle), the test will fail.

I propose to continue the same way until some test will not pass due to changes on the staging server. If it occurs we should have a small general discussion on the structure of the api calling tests.

@cmutel Can you review the pull request and merge it into main?

tfardet commented 1 year ago

@cmutel give me a sec, I'll fix get_node_type behavior