brightway-lca / bw_processing

Tools to create structured arrays in a common format
https://docs.brightway.dev/projects/bw-processing/
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Move from `fs` (pyfilesystem) to `fsspec` #65

Closed michaelweinold closed 6 months ago

michaelweinold commented 6 months ago

As suggested by @cmutel, moving to fsspec would solve two issues with fs (pyfilesystem):

  1. The package is currently not under active development
  2. Code of the sort if not _WINDOWS_PLATFORM: import grp causes an error in WASM (Pyodide/JupyterLite-XEUS):

Note that this was patched in the current https://live.brightway.dev release:

import micropip
await micropip.install(
    'https://files.brightway.dev/fs-2.5.1-py2.py3-none-any.whl'
)

Still, it would be great to move to fsspec, which is supported by both Pyodide and emscipten-forge (via the pure Python channel).

This would close:

cmutel commented 6 months ago

@michaelweinold Told you this was a dirty hack 😛

cmutel commented 6 months ago

Fixed in #66

michaelweinold commented 6 months ago

Noice! 🎉 Will remove the custom patch with the next bw_procesing release!