search

brightway-lca / bw_recipe_2016

ReCiPe 2016 LCIA method for Brightway
BSD 3-Clause "New" or "Revised" License
4 stars 4 forks source link

Bug fixes for importing ReCiPe 2016 impact categories into bw projects #7

Closed juweya closed 3 years ago

juweya commented 3 years ago

land.py: Categories where missing for the land transformation impact category causing an error down the road when trying to match the biosphere flows of the characterisation factors with the ones in the biosphere database in match_multiple. The strategy reset_categories was used to avoid this error analogous to the land occupation category.

string_manipulation.py: An error occured in some cases where the key "synonyms" existed but its value was None. Workaround uses dict.get() method which returns the value if the key exists or None if the key does not exist causing the following lines to be skipped as well if the value is None.

cmutel commented 3 years ago

@juweya I don't know who you are, but I very much appreciate your work in the last months! Sorry about the delayed response, I am not getting notified about PRs and so only see them at random (which is very frustrating).