Rounding dates instead of cutting off

brightway-lca / bw_timex

Time-explicit Life Cycle Assessment

https://docs.brightway.dev/projects/bw-timex

BSD 3-Clause "New" or "Revised" License

28 stars 5 forks source link

Rounding dates instead of cutting off #95

Closed TimoDiepers closed 1 week ago

TimoDiepers commented 1 week ago

Instead of always rounding off the dates in the timeline (using the resolution specified in temporal_grouping), this rounds them to the nearest year/month/day/hour (depending on temporal_grouping).

Accordingly, if I run a TimexLCA with a demand for today, the timeline says the date is 2025-01-01 which I find somewhat weird, but is probably more correct than 2024-01-01 in a sense.

TimoDiepers commented 1 week ago

note: this also "fixes" the currently failing tests