search

brightwind-dev / brightwind

Python library containing wind analysis functions
MIT License
49 stars 18 forks source link

[plot_scatter_wspd & plot_scatter_dir] Legend entries swapped #443

Open AndyBrightWind opened 2 months ago

AndyBrightWind commented 2 months ago

Describe the bug The above two functions plot a scatter of input data points, along with a 1:1 trendline. However, the labels on the two legend entries are swapped, with '1:1 line' appearing by the green data points, and 'Data points' appearing by the black line.

To Reproduce Download any dataset, then run bw.plot_scatter_wspd(x_wspd_series, y_wspd_series) or bw.plot_scatter_wdir(x_wdir_series, y_wdir_series)

Expected behavior The label 'Data points' should appear beside the green data points, and '1:1 line' should appear beside the black line.

Screenshots

image

Additional context N/A

Proposed solution Swap the legend labels within both functions.

stephenholleran commented 2 months ago

@rach185 are you able to take a look at this? Thanks,

rach185 commented 4 weeks ago

Issue addressed on this branch, forgot to tag https://github.com/brightwind-dev/brightwind/tree/iss443_scatter_plot_label