search

brihmon / sheel-ma3aya

Automatically exported from code.google.com/p/sheel-ma3aya
0 stars 0 forks source link

HS (Review Mohsen's tasks) #120

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
================
Task
================
Review Mohsen's tasks.

Original issue reported on code.google.com by hossam.a...@gmail.com on 9 Dec 2011 at 7:57

GoogleCodeExporter commented 9 years ago

Original comment by hossam.a...@gmail.com on 9 Dec 2011 at 7:58

GoogleCodeExporter commented 9 years ago 
started

1-

De-activate is allowed the offer multiple requests

2-

Action bar positioning is not good

3-

Edits are working

4-

I am not sure that the edits are working on the DB,

since i did not feel the change on the UI.. do you have a clue?

Original comment by hossam.a...@gmail.com on 25 Dec 2011 at 11:21

GoogleCodeExporter commented 9 years ago 
If u change something in the offer, u can simply reload the "my offers"
list from the menu and the changes
will be there. you can also simply check the datastore.
I dont have control over the list UI, therefore I cannot refresh it after
the changes.

Original comment by amohsen1989@gmail.com on 26 Dec 2011 at 5:18

GoogleCodeExporter commented 9 years ago 
I dunno,,,, but i feel as a usability wise the task of changing the offer 
content is not that complete.

Original comment by hossam.a...@gmail.com on 27 Dec 2011 at 1:56

GoogleCodeExporter commented 9 years ago 
ok

Original comment by amohsen1989@gmail.com on 27 Dec 2011 at 7:15

GoogleCodeExporter commented 9 years ago 
After Mohsen is done with his merging of tasks

I have checked his tasks.. all went fine.

However my comments are:

1- the shape of the action bar does not look good
2- the list is not updated upon any action he has done.. we must get the 
requests from the very begning (refresh the page)

Original comment by hossam.a...@gmail.com on 4 Jan 2012 at 12:56