briis / hass-weatherflow

Home Assistant Integration for WeatherFlow Stations
MIT License
69 stars 11 forks source link

Unit of Measurement Consistency with HA and other Integrations #57

Closed mwolter805 closed 1 year ago

mwolter805 commented 1 year ago

Hello, Noticed there is a unit_of_measurement inconsistency with other integrations and sensors. This became apparent when attempting to compare measurements from the hass-weatherflow and Thermal Comfort integrations.

As you can see in the screenshot below, because the unit_of_measurement is not consistent between the sensors, the scales do not match and the values can not be easily compared. Screenshot 2023-02-10 at 11 27 32 AM

In the graph, "Back Patio" is a sensor from hass-weatherflow and uses the unit of measurement "g/m^3" the other two sensors are from Thermal Comfort and use the unit of measurement "g/m³". Note, hass-weatherflow uses the carrot symbol (^) to indicate power when Thermal Comfort uses the cubed symbol.

In spirit of consistency and compatibility with Home Assistant, when reviewing these documents, it appears all units for area or volume use the cubed (³) or squared (²) symbol and not the carrot symbol (ie ^3, or ^2).

Although there could be more, it appears there are two sensors created by hass-weatherflow that use carrot. Screenshot 2023-02-10 at 11 22 02 AM

Would it be possible to update the units of sensors created by hass-weatherflow and possibly hass-weatherflow2mqtt to be more consistent with Home Assistant?

Regards, Matt

briis commented 1 year ago

Fixed with release 1.0.13.

mwolter805 commented 1 year ago

@briis Looks like an incorrect unit was used. Appears that micro grams per cubic meter (µg/m³) was used instead of grams per cubic meter (g/m³). Screenshot 2023-02-11 at 8 39 16 AM

briis commented 1 year ago

Ups - You are right. Fixed with 1.0.14

mwolter805 commented 1 year ago

perfect, thanks