search

briis / hass-weatherflow

Home Assistant Integration for WeatherFlow Stations
MIT License
68 stars 11 forks source link

correct units but incorrect values? #9

Closed jsermer closed 2 years ago

jsermer commented 2 years ago

I have both integrations installed side by side and they both reflect F (for temp units), but the new integration shows incorrect values. For example, current temp on the old one shows 37 degrees, but the new one shows 99 degrees.

image

vs

image

jsermer commented 2 years ago

I haven't read thru the code just yet, but i did a quick curl against the api and see even though my device reports units of F, the units are still emitted in C:

at 17:47:13 ❯ curl -s https://swd.weatherflow.com/swd/rest/observations/station/ID?token=TOKEN | jq -r '.station_units.units_temp,.obs[0].air_temperature'
f
3.9
CommittotheIndian commented 2 years ago

I'm seeing the same issue. I just updated to 1.10 today and my temps are off but don't convert from F to C.

It is currently 57F which should convert to 13.8 but the integration is showing 134.1F.

image

jonathanjmakela commented 2 years ago

Same issue. It appears to assume the value read in is in C and then is converting to F (@CommittotheIndian , 57 C converts to 134 F). In sensor.py, it seems to hard code all of the temperature units to TEMP_CELSIUS.

briis commented 2 years ago

Thanks. Will be fixed in a few hours. Made a change in one place, and forgot to reflect this in another place.

briis commented 2 years ago

V0.1.11 is now released which fixes this issue. I will close this now, please re-open if you still see issues.